On Thu, 24 Aug 2017 17:49:47 +0200, Mark Brown wrote: > > On Thu, Aug 24, 2017 at 04:33:29PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > On Thu, Aug 24, 2017 at 04:41:10PM +0300, Andy Shevchenko wrote: > > > > > > > There is no platform code that uses i2c module table. > > > > Remove it altogether and adjust ->probe() to be ->probe_new(). > > > > What is the value in doing this? Removing the ability to instantiate > > > via board files is just inconveniencing people doing that, it's not a > > > goal in itself. > > > But the id table is already empty...? > > Right, that seems like a bug though. Well, that's what the commit ddc9e69b9dc2 does after all: it cleans up the legacy usage, and moves all either OF or ACPI matching. If we want to take back old i2c ids, better to put the explicit i2c_match_id() check in rt5677_i2c_probe() instead of sticking with the old i2c probe callback. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
