Hi, Takashi I think we can submit my patch first, then generate another patch to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove hda_eld.o from snd-hda-codec-xxhdmi-objs. Thanks Wei. nvpublic -----Original Message----- From: Takashi Iwai [mailto:tiwai@xxxxxxx] Sent: Thursday, March 04, 2010 5:47 PM To: Wei Ni Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm' Subject: Re: [PATCH]Support MCP89 and GT21x hdmi audio At Thu, 4 Mar 2010 10:21:39 +0800, Wei Ni wrote: > > Hi, Takashi > 1. Yes, it can works for all Nvidia controller. OK. > 2. The hda_eld.o doesn't export any symbols. > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o > from snd-had-codec-intelhdmi-objs, but it will build error. It need > to modify hda_eld.c to export symbols, it will add many changes. Yes, this is unavoidable. Please add EXPORT_SYMBOL()'s appropriately. We can reduce them again once after all HDMI stuff is merged into one. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
