At Wed, 3 Mar 2010 15:21:12 +0800,
Wei Ni wrote:
>
> Hi, Takashi
> I generate the new patch file, please check it.
Thanks. Review comments below:
> @@ -1367,6 +1368,7 @@ static void azx_bus_reset(struct hda_bus *bus)
>
> /* number of codec slots for each chipset: 0 = default slots (i.e. 4) */
> static unsigned int azx_max_codecs[AZX_NUM_DRIVERS] __devinitdata = {
> + [AZX_DRIVER_NVIDIA] = 8,
Are you sure that this works for all Nvidia controller chips including
the old nForce chipset?
> diff --git a/sound/pci/hda/Makefile b/sound/pci/hda/Makefile
> index 315a1c4..199f440 100644
> --- a/sound/pci/hda/Makefile
> +++ b/sound/pci/hda/Makefile
> @@ -17,7 +17,7 @@ snd-hda-codec-cirrus-objs := patch_cirrus.o
> snd-hda-codec-ca0110-objs := patch_ca0110.o
> snd-hda-codec-conexant-objs := patch_conexant.o
> snd-hda-codec-via-objs := patch_via.o
> -snd-hda-codec-nvhdmi-objs := patch_nvhdmi.o
> +snd-hda-codec-nvhdmi-objs := patch_nvhdmi.o hda_eld.o
> snd-hda-codec-intelhdmi-objs := patch_intelhdmi.o hda_eld.o
This is buggy. You cannot create multiple modules containing the
same *.o file that exports symbols.
Instead, put hda_eld.o to snd-hda-codec-* (currently commented out),
and remove hda_eld.o from snd-hda-codec-intelhdmi-objs.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
