On 04/09/2023 13:46, wangweidong.a@xxxxxxxxxx wrote:
> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>
> Add a DT schema for describing awinic aw87390 audio amplifiers.
> They are controlled using I2C.
Thank you for your patch. There is something to discuss/improve.
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: awinic,aw87390
> +
> + reg:
> + maxItems: 1
No reset-gpios? Shouldn't this be just merged with awinic,aw88395 bindings?
Missing sound-dai-cells (const: 0 or 1)
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + audio-codec@58 {
> + compatible = "awinic,aw87390";
> + reg = <0x58>;
Please add sound-dai-cells for the example to be complete.
Best regards,
Krzysztof
