On 04/09/2023 13:46, wangweidong.a@xxxxxxxxxx wrote:
> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>
...
> +static void aw87390_parse_channel_dt(struct aw87390 *aw87390)
> +{
> + struct aw_device *aw_dev = aw87390->aw_pa;
> + struct device_node *np = aw_dev->dev->of_node;
> + u32 channel_value = AW87390_DEV_DEFAULT_CH;
> +
> + of_property_read_u32(np, "sound-channel", &channel_value);
NAK, there is no such property. It seems you already sneaked in such for
other codecs. Please do not repeat such patterns of work.
That's also why I expect full DTS example, not some reduced pieces.
> +
> + aw_dev->channel = channel_value;
> +}
> +
> +static int aw87390_init(struct aw87390 **aw87390, struct i2c_client *i2c, struct regmap *regmap)
> +{
> + struct aw_device *aw_dev;
> + unsigned int chip_id;
> + int ret;
> +
> + /* read chip id */
> + ret = regmap_read(regmap, AW87390_ID_REG, &chip_id);
> + if (ret) {
> + dev_err(&i2c->dev, "%s read chipid error. ret = %d\n", __func__, ret);
> + return ret;
> + }
> +
> + if (chip_id != AW87390_CHIP_ID) {
> + dev_err(&i2c->dev, "unsupported device\n");
Why? The compatible tells it cannot be anything else.
> + return -ENXIO;
> + }
> +
> + dev_info(&i2c->dev, "chip id = 0x%x\n", chip_id);
> +
> + aw_dev = devm_kzalloc(&i2c->dev, sizeof(*aw_dev), GFP_KERNEL);
> + if (!aw_dev)
> + return -ENOMEM;
> +
> + (*aw87390)->aw_pa = aw_dev;
> + aw_dev->i2c = i2c;
> + aw_dev->regmap = regmap;
> + aw_dev->dev = &i2c->dev;
> + aw_dev->chip_id = AW87390_CHIP_ID;
> + aw_dev->acf = NULL;
> + aw_dev->prof_info.prof_desc = NULL;
> + aw_dev->prof_info.count = 0;
> + aw_dev->prof_info.prof_type = AW88395_DEV_NONE_TYPE_ID;
> + aw_dev->channel = AW87390_DEV_DEFAULT_CH;
> + aw_dev->fw_status = AW87390_DEV_FW_FAILED;
> + aw_dev->prof_index = AW87390_INIT_PROFILE;
> + aw_dev->status = AW87390_DEV_PW_OFF;
> +
> + aw87390_parse_channel_dt(*aw87390);
> +
> + return ret;
> +}
> +
> +static int aw87390_i2c_probe(struct i2c_client *i2c)
> +{
> + struct aw87390 *aw87390;
> + int ret;
> +
> + ret = i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C);
> + if (!ret)
> + return dev_err_probe(&i2c->dev, -ENXIO, "check_functionality failed\n");
> +
> + aw87390 = devm_kzalloc(&i2c->dev, sizeof(*aw87390), GFP_KERNEL);
> + if (!aw87390)
> + return -ENOMEM;
> +
> + mutex_init(&aw87390->lock);
> +
> + i2c_set_clientdata(i2c, aw87390);
> +
> + aw87390->regmap = devm_regmap_init_i2c(i2c, &aw87390_remap_config);
> + if (IS_ERR(aw87390->regmap)) {
> + ret = PTR_ERR(aw87390->regmap);
ret is not needed here, so just:
return dev_err_probe()
> + return dev_err_probe(&i2c->dev, ret, "failed to init regmap: %d\n", ret);
> + }
> +
> + /* aw pa init */
> + ret = aw87390_init(&aw87390, i2c, aw87390->regmap);
> + if (ret)
> + return ret;
> +
> + ret = regmap_write(aw87390->regmap, AW87390_ID_REG, AW87390_SOFT_RESET_VALUE);
> + if (ret)
> + return ret;
> +
> + ret = devm_snd_soc_register_component(&i2c->dev,
> + &soc_codec_dev_aw87390, NULL, 0);
> + if (ret)
> + dev_err(&i2c->dev, "failed to register aw87390: %d\n", ret);
> +
> + return ret;
> +}
Best regards,
Krzysztof
