On Thu, 18 May 2023 16:09:45 +0200, Oswald Buddenhagen wrote: > -static int snd_emu10k1_pcm_channel_alloc(struct snd_emu10k1_pcm * epcm, int voices) > +static void snd_emu10k1_pcm_free_voices(struct snd_emu10k1_pcm *epcm) > { > - int err, i; > - > - for (i = 0; i < ARRAY_SIZE(epcm->voices); i++) { > + for (unsigned i = 0; i < ARRAY_SIZE(epcm->voices); i++) { We don't use this style. Declare the variable outside the for(). Also, as usual, it'd be still helpful if you show this is merely a code simplification without any functional change in the commit log. thanks, Takashi