On Thu, 18 May 2023 15:58:51 +0200, Oswald Buddenhagen wrote: > > On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote: > > smatch reports > ^^^^^^ is this the best word to use here? Note that smatch is a name of a static analysis tool :) > > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol > > 'emu1010_routing_info' was not declared. Should it be static? > > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol > > 'emu1010_pads_info' was not declared. Should it be static? > > > > These variables are only used in their defining file, so it should be static > ^^ they > > > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > > > Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > (also amending one of the still pending patches. thanks!) Applied the patch now, thanks. Takashi
