Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/18/23 6:58 AM, Oswald Buddenhagen wrote:
On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
smatch reports
 ^^^^^^ is this the best word to use here?

I have been running smatch against the whole tree for a while, using this preamble.

Many fixes later, for the most part the tree has been cleaned of this class of problems.

Tom


sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
 'emu1010_routing_info' was not declared. Should it be static?
sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
 'emu1010_pads_info' was not declared. Should it be static?

These variables are only used in their defining file, so it should be static
                              ^^ they

Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>

(also amending one of the still pending patches. thanks!)

regards





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux