On Thu, May 18, 2023 at 04:53:19PM +0200, Takashi Iwai wrote:
On Thu, 18 May 2023 16:09:45 +0200,
Oswald Buddenhagen wrote:
-static int snd_emu10k1_pcm_channel_alloc(struct snd_emu10k1_pcm * epcm, int voices)
+static void snd_emu10k1_pcm_free_voices(struct snd_emu10k1_pcm *epcm)
{
- int err, i;
-
- for (i = 0; i < ARRAY_SIZE(epcm->voices); i++) {
+ for (unsigned i = 0; i < ARRAY_SIZE(epcm->voices); i++) {
We don't use this style. Declare the variable outside the for().
ehm ...
- "we" seems to be mostly true for alsa. but looking at the kernel as a
whole, that ship has sailed since the adoption of c11. maybe time to
adapt?
- you're noticing this a bit late, after already merging 8 instances.
how should i proceed?
Also, as usual, it'd be still helpful if you show this is merely a
code simplification without any functional change in the commit log.
right. i don't always remember to pre-emptively amend the patches i
wrote quite a while ago ...
regards
