On Fri, Sep 2, 2022 at 10:46 AM Cezary Rojewski <cezary.rojewski@xxxxxxxxx> wrote: > On 2022-09-01 9:34 PM, Andy Shevchenko wrote: > > On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski > > <cezary.rojewski@xxxxxxxxx> wrote: ... > >> +int tokenize_user_input(const char __user *from, size_t count, int **tkns); > > > > Not sure how I can deduct from the name what function is actually > > doing. Suggested new name: int_array_parse_user(). > > > > int int_array_parse_user(const char __user *from, size_t count, int **array); > > > > (Note that we have _user suffix for many APIs in the kernel that does > > interact with user space memory) > > That's why I've added '_user_' in the middle! Anyway, I guess the > expectation is that it's a suffix - precisely at the end of the name. > > Could we reorder it a bit: "parse_int_array_user"? Most of the exported functions that have 'parse' word, have it after namespace, but in this case there is no dedicated namespace and it also will be in alignment with parse_options_str. That said, go for it. -- With Best Regards, Andy Shevchenko
