On 2022-09-01 9:34 PM, Andy Shevchenko wrote:
On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski
<cezary.rojewski@xxxxxxxxx> wrote:
...
+int tokenize_user_input(const char __user *from, size_t count, int **tkns);
Not sure how I can deduct from the name what function is actually
doing. Suggested new name: int_array_parse_user().
int int_array_parse_user(const char __user *from, size_t count, int **array);
(Note that we have _user suffix for many APIs in the kernel that does
interact with user space memory)
That's why I've added '_user_' in the middle! Anyway, I guess the
expectation is that it's a suffix - precisely at the end of the name.
Could we reorder it a bit: "parse_int_array_user"?
+ * @tkns: Returned pointer to sequence of integers
array
Ack.
If you are okay with this, you may add my
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
