On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski <cezary.rojewski@xxxxxxxxx> wrote: > > Add new helper function to allow for splitting specified user string > into a sequence of integers. Internally it makes use of get_options() so > the returned sequence contains the integers extracted plus an additional > element that begins the sequence and specifies the integers count. Thanks! In general it looks good to me, but a few minor comments below. ... > +int tokenize_user_input(const char __user *from, size_t count, int **tkns); Not sure how I can deduct from the name what function is actually doing. Suggested new name: int_array_parse_user(). int int_array_parse_user(const char __user *from, size_t count, int **array); (Note that we have _user suffix for many APIs in the kernel that does interact with user space memory) ... > + * @tkns: Returned pointer to sequence of integers array ... If you are okay with this, you may add my Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko
