On Tue, Nov 16, 2021 at 06:44:06PM -0000, Simon Trimmer wrote: > > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Simon Trimmer <simont@xxxxxxxxxxxxxxxxxxxxx> > > > --- > > > > This has Simon's signoff after yours but no other indication of his > > involvement? > > I have been working with Charles on most of these patches over the last few > months and I'd fixed some internal review comments on this one before we > shared it. If it helps I can certainly ack the chain? > Yeah apologies I am never quite sure what to do in this situation. We internally have someone add their sign-off when they make a change to a patch. I could change this to a Co-authored-by: if that is the preferred upstream approach? Thanks, Charles