> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Tuesday, November 16, 2021 6:08 PM > To: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > Cc: lgirdwood@xxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxx; alsa-devel@alsa- > project.org > Subject: Re: [PATCH 03/10] firmware: cs_dsp: Add version checks on coefficient > loading > > On Tue, Nov 16, 2021 at 04:16:02PM +0000, Charles Keepax wrote: > > The firmware coefficient files contain version information that is > > currently ignored by the cs_dsp code. This information specifies which > > version of the firmware the coefficient were generated for. Add a check > > into the code which prints a warning in the case the coefficient and > > firmware differ in version, in many cases this will be ok but it is not > > always, so best to let the user know there is a potential issue. > > > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Simon Trimmer <simont@xxxxxxxxxxxxxxxxxxxxx> > > --- > > This has Simon's signoff after yours but no other indication of his > involvement? I have been working with Charles on most of these patches over the last few months and I'd fixed some internal review comments on this one before we shared it. If it helps I can certainly ack the chain?
