Re: [PATCH v5 2/2] ASoC: codec: tlv320adc3xxx: New codec driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ricard,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on v5.16-rc1 next-20211117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ricard-Wanderlof/Codec-driver-for-TLV320ADC3001-and-3101/20211116-003414
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: openrisc-buildonly-randconfig-r004-20211116 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/550b41b1ba4e75516ae8f83112fe2de974e9f579
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ricard-Wanderlof/Codec-driver-for-TLV320ADC3001-and-3101/20211116-003414
        git checkout 550b41b1ba4e75516ae8f83112fe2de974e9f579
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

>> sound/soc/codecs/tlv320adc3xxx.c:1068:1: warning: data definition has no type or storage class
    1068 | module_i2c_driver(adc3xxx_i2c_driver);
         | ^~~~~~~~~~~~~~~~~
>> sound/soc/codecs/tlv320adc3xxx.c:1068:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
>> sound/soc/codecs/tlv320adc3xxx.c:1068:1: warning: parameter names (without types) in function declaration
   sound/soc/codecs/tlv320adc3xxx.c:1058:26: warning: 'adc3xxx_i2c_driver' defined but not used [-Wunused-variable]
    1058 | static struct i2c_driver adc3xxx_i2c_driver = {
         |                          ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +1068 sound/soc/codecs/tlv320adc3xxx.c

  1067	
> 1068	module_i2c_driver(adc3xxx_i2c_driver);
  1069	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux