Re: Quality resampling code for libasound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Wed, 21 Mar 2007 00:22:28 +1100,
Jean-Marc Valin wrote:
> 
> Hi,
> 
> I'm attaching an updated version of my resampler plugin. It fixes a few
> minor issues and it adds support for fixed-point processing (just add
> -DFIXED_POINT to the build). Let me know if there's any problem.

Thanks.
It would be helpful if you provide a diff rather a complete tarball at
the next time.

> diff -r 0bcf6f07c12c pph/rate_speexrate.c
> --- a/pph/rate_speexrate.c	Thu Mar 08 12:54:57 2007 +0100
> +++ b/pph/rate_speexrate.c	Tue Mar 20 14:08:30 2007 +0100
> @@ -29,6 +29,7 @@
>  */
>  
>  #include <stdio.h>
> +#include <samplerate.h>
>  #include <alsa/asoundlib.h>

This requires additional check in configure.
Why is this header needed now?

> @@ -42,7 +43,7 @@ struct rate_src {
>  
>  static snd_pcm_uframes_t input_frames(void *obj, snd_pcm_uframes_t frames)
>  {
> -   int num, den;
> +   spx_uint32_t num, den;

I don't see big merits to use its own types here...


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux