At Wed, 21 Feb 2007 20:18:10 +1100, Jean-Marc Valin wrote: > > > I've been having some problems with my plugin and trying to debug it, > > I've discovered what seems to be massive memory corruption in the rate > > converter plugin layer. It's actually not just with my plugin, but also > > with the libsamplerate plugin. > > OK, so it turns out that the main bug wasn't in the plugin layer (though > it could definitely be more robust), but in the original rate_samplerate > plugin itself which had input_frames() and output_frames() actually > implemented in reverse. Thanks, now committed to HG tree. > So I'm attaching both a patch for rate_samplerate and a new version of > my resampler plugin (now BSD-licensed). Both seem to work much better > with the numerator and denominator in the right place. I still haven't > changed the code to resolve the symbol conflict, but I'll do that soon. Regarding the license, LGPL would be suitable especailly if thinking about merging the code to alsa-lib tree later. Other codes in alsa-lib are all LGPL, so putting a BSD piece isn't fun. The license can be changed at merge time, though. Of course, if you prefer BSD, it's fine. We can keep it as is. > Can everyone give this a bit of testing? I hope we can soon get rid of > linear resampling as the default resampling once and for all. Looks working good as long as I've tested. Could you give a short document for this plugin, too (put in alsa-firmware/doc)? Thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
