Re: Quality resampling code for libasound

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 08 Mar 2007 11:59:13 +1100,
Jean-Marc Valin wrote:
> 
> > Don't hurry up.  We are still in a long rc phase :)
> > Let's check with the latest 1.0.14rc3 and see the performance.
> > Making it as default is so easy to add one line to /etc/alsa.conf (or
> > ~/.asoundrc) as found in the documentation.
> 
> OK, hopefully that can happen for 1.1.14... Did you actually test my
> plugin yet to see whether it works as expected?

Yes, it has been working well as far as I've tested.

> >> OK, did a bit of search/replace on samplerate.txt and attached the
> >> result. As you can see, it's fairly similar. So far, I'm also including
> >> 3 levels of quality that match the libsamplerate levels, but I can
> >> change that depending on what people want.
> > 
> > Thanks.  I guess the title should be changed (I already took the fixed
> > version on my local tree).
> 
> Oops :-)
> 
> >> The Speex resampler offers
> >> quality settings that range from 0 to 10, so I can expose them all (is
> >> there a way to pass a quality parameter to the resampler instead of
> >> having to create lots of symbolic links?).
> > 
> > We can extend the rate plugin API so that the plugin code can refers
> > the config parameters.  But this would require an ABI extension /
> > incompatibility.  So I'd like to avoid this as much as possible.
> > 
> > I don't think we need to expose all 11 ranges.  Three should be
> > enough, normally...
> 
> I think we can live with 3 settings, at least for now. The libsamplerate
> plugin had 5 settings, of which only 3 were useful (I used equivalent
> quality to those) -- the other 2 were zero-order hold and linear
> interpolation, which nobody in their right mind would want to use!
> 
> One last thing, what happened to the other patch I sent for doing
> rounding-to-nearest (instead of rounding down) when doing sample format
> conversion?

Sorry, forgotten until now.  Applied with slight modification
(introducing a macro) to HG tree now.  Thanks for ping!


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux