Re: [PATCH] hda: add sigmatel dig mic support and refactor 9227

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 26, 2006 at 01:02:30PM +0200, Takashi Iwai wrote:
> You cannot remove XXX_MODELS.
> The size of *_brd_tbl[] must be defined as the max number of models.
> Otherwise you might access to outside the array since the driver
> checks the value of *_brd_tbl[model].

Ahh, yes. Whoops. 

> Also, some lines you added exceed 80-columns rule.  I know there are
> still more lines over 80 chars,  but let's follow the standard coding
> style at least for new codes.

Ok, will do. I'm sending a separate patch which just adds 9205
dmic support and we can address the 927x/9227 issue separately.

-Matt

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux