Re: [PATCH] hda: add sigmatel dig mic support and refactor 9227

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Wed, 25 Oct 2006 16:21:10 -0400,
Matt Porter wrote:
> @@ -41,10 +41,8 @@
>  #define STAC_D945GTP3		1
>  #define STAC_D945GTP5		2
>  #define STAC_MACMINI		3
> -#define STAC_922X_MODELS	4	/* number of 922x models */
>  #define STAC_D965_3ST		4
>  #define STAC_D965_5ST		5
> -#define STAC_927X_MODELS	6	/* number of 922x models */

You cannot remove XXX_MODELS.
The size of *_brd_tbl[] must be defined as the max number of models.
Otherwise you might access to outside the array since the driver
checks the value of *_brd_tbl[model].

Also, some lines you added exceed 80-columns rule.  I know there are
still more lines over 80 chars,  but let's follow the standard coding
style at least for new codes.


Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux