Re: [RFC] Add dB scale information to AK4xxx codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 07 Sep 2006 14:49:24 +0200,
I wrote:
> 
> At Thu, 7 Sep 2006 12:00:30 +0100,
> Jochen Voss wrote:
> > 
> > Hello Takashi,
> > 
> > On Thu, Sep 07, 2006 at 12:33:18PM +0200, Takashi Iwai wrote:
> > > Yes.  Then we need to take the controls back to a single one.
> > > Will do later.
> > Ok.
> > 
> > > I still wonder whether this is also true for AK4524...
> > No idea about this, I do not have an AK4524 so I cannot test.
> > 
> > > > > Also, it's possible that I did make a silly mistake.  Put a debug
> > > > > printk around ak->ops.write() in snd_akm4xxx_write() to check what
> > > > > values are written to register 4 and 5.
> > > > 
> > > > I will try this in the evening.
> > 
> > This sounded more fun than the simulation I am supposed to do for work,
> > so I sneaked away and did this first ;-)
> > 
> > I used the following printk:
> > 
> > ======================================================================
> > --- ak4xxx-adda.c~      2006-08-31 01:00:11.000000000 +0100
> > +++ ak4xxx-adda.c       2006-09-07 11:49:57.394999424 +0100
> > @@ -40,6 +40,9 @@
> >                        unsigned char val)
> >  {
> >         ak->ops.lock(ak, chip);
> > +       if (ak->type == SND_AK5365 && (reg==4 || reg==5)) {
> > +         printk (KERN_INFO "reg%d <- %02x\n", reg, val);
> > +       }
> >         ak->ops.write(ak, chip, reg, val);
> >  
> >         /* save the data */
> > ======================================================================
> > 
> > Results from my second test (s2.sh vs s3.sh):
> > 
> > s2.sh: The commands
> > 
> >     amixer set "PCM Capture Gain" 0
> >     amixer set "PCM Capture Gain" 20
> >     amixer set "PCM" 0
> >     amixer set "PCM" 80%
> > 
> > translate into
> > 
> >     reg4 <- 80
> >     reg5 <- 80
> >     reg4 <- 94
> >     reg5 <- 94
> >     reg4 <- 00
> >     reg5 <- 00
> >     reg4 <- 5e
> >     reg5 <- 5e
> > 
> > s3.sh: The commands
> > 
> >     amixer set "PCM" 0
> >     amixer set "PCM" 80%
> >     amixer set "PCM Capture Gain" 0
> >     amixer set "PCM Capture Gain" 20
> > 
> > translate into
> > 
> >     reg4 <- 00
> >     reg5 <- 00
> >     reg4 <- 5e
> >     reg5 <- 5e
> >     reg4 <- 80
> >     reg5 <- 80
> >     reg4 <- 94
> >     reg5 <- 94
> > 
> > This seems to be the expected register assignments.  As stated before,
> > these settings lead to different recording volume.
> 
> OK, thanks for confirmation.
> 
> The untested patch for removing IPGA is below.  Please give it a
> shot. 
> 
> I'll check a board with AK4524 (well I have to dig the boxes) whether
> it shows shows the same behavior like AK5365.

I confirmed that the same behavior appears on AK4524.
So, it makes much more sense to combine ADC and IPGA controls to a
single control.

The patch below is the final version I have on my local tree.
Please check whether it works for you.

FYI, the second patch is for envy24control to make it work correctly
after changing ADC ranges.


Takashi

Attachment: ak4xxx-adda-ipga-fix.diff
Description: Binary data

Attachment: envy24-ipga-fix.diff
Description: Binary data

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux