> think you might have overdone it a little bit (IMO) what about just
> using fnmatch wildcards for now and adding the other types of matches
> when they are needed?
I am thinking of other clients that might want more flexibility
or another option --enablerepo-re=<regex>
(first on my wishlist is to replace fnmatch with a translator that
will expand braces:
fedora-3-{stable,testing}
)
> I also noticed the comment for enableRepo says
> 'disable a repository from use' instead of enable, but that seems to
> be a bug in the original yum source code.
oops.
> Two general questions/considerations:
> 1) Is there a reason for letting findRepos return a generator instead
> of a tuple or list?
Since we are targeting 2.2+, there is no reason to not return a generator (IMO).
Someone who wants a list can say list(findRepos(pat))
> 2) Should there be a warning or error when someone specifies a
> wildcard that matches nothing (for example --disablerepo=mispelled-*)?
Yes, but I didn't notice any particularly obvious way to do that.
If there were a logging object floating around, I would say
log.warn("wildcard pattern did not match any repository %s",pat)
but I didn't notice any other code in repos.py doing that.
> > P.S. Is this the right way to submit patches?
> There is also a yum-devel list that might be more appropriate.
ok.
