[Crash-utility] Re: Revert "arm64: section_size_bits compatible with macro definitions"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 9, 2024 at 2:05 PM Tao Liu <ltao@xxxxxxxxxx> wrote:
>
> Hi Guanyou,
>
> On Tue, Oct 8, 2024 at 10:30 PM Guanyou Chen <chenguanyou9338@xxxxxxxxx> wrote:
> >
> > Hi tao, lianbo
> >
> > Will it be merged before version 8.0.6 ?
>
> Yes, I'm handling it, will be merged shortly.

Merged with some modifications on the commit log:

https://github.com/crash-utility/crash/commit/32b03ca26229bf587652952e0ca348354c5dffc5

Thanks,
Tao Liu

>
> Thanks,
> Tao Liu
>
> >
> > Guanyou Chen <chenguanyou9338@xxxxxxxxx> 于2024年9月20日周五 14:54写道:
> >>
> >> Thanks for the feedback!
> >>
> >> Tao Liu <ltao@xxxxxxxxxx> 于2024年9月11日周三 11:02写道:
> >>>
> >>> Hi lianbo,
> >>>
> >>> On Wed, Sep 11, 2024 at 2:32 PM lijiang <lijiang@xxxxxxxxxx> wrote:
> >>> >
> >>> > On Mon, Sep 9, 2024 at 2:16 PM Tao Liu <ltao@xxxxxxxxxx> wrote:
> >>> >>
> >>> >> Hi Guanyou & lianbo,
> >>> >>
> >>> >> I re-thought about the patch, and I agree the revert patch should be
> >>> >> applied, the reverted code is already covered by the previous:
> >>> >>
> >>> >> if (THIS_KERNEL_VERSION >= LINUX(5,12,0)) {
> >>> >> ...
> >>> >> else
> >>> >> ...
> >>> >>
> >>> >> hunk, so there is no need for the
> >>> >> CONFIG_ARM64_4K_PAGES/CONFIG_ARM64_16K_PAGES checks here. Previously
> >>> >> the patch was applied for the compatibility of android kernel due to
> >>> >> its customization, mainline kernel won't need this.
> >>> >>
> >>> >> What do you think? @Lianbo Jiang
> >>> >
> >>> >
> >>> > Sorry for the late reply, Tao and Guanyou.
> >>> >
> >>> > I agree with you, let's revert this one(because that patch seems not needed.)
> >>> >
> >>> Agreed, let's go with the revert.
> >>>
> >>> Thanks,
> >>> Tao Liu
> >>>
> >>> > Thanks
> >>> > Lianbo
> >>>
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux