On Mon, Nov 14, 2011 at 09:30:01PM -0700, Eric Blake wrote: > From: Hu Tao <hutao@xxxxxxxxxxxxxx> > > This adds per-device weights to <blkiotune>. Note that the > cgroups implementation only supports weights per block device, > and not per-file within the device; hence this option must be > global to the domain definition rather than tied to individual > <devices>/<disk> entries: > > <domain ...> > <blkiotune> > <device> > <path>/path/to/block</path> > <weight>1000</weight> > </device> > </blkiotune> > .. > > This patch also adds a parameter --device-weights to virsh command > blkiotune for setting/getting blkiotune.weight_device for any > hypervisor that supports it. All <device> entries under > <blkiotune> are concatenated into a single string attribute under > virDomain{Get,Set}BlkioParameters, named "device_weight". I don't entirely like the concatenation of devices into device_weight, but I don't see a good alternative given the API design. ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list