On 02/16/2011 09:41 AM, Eric Blake wrote: > On 02/16/2011 09:01 AM, Jiri Denemark wrote: >> Even VPATH make dist succeeds now > > ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c > code, and since it makes the tarball more useful. I still maintain the ACK, and would like to see this go in as-is. However, this patch is incomplete... > > And I'm going to dig up my attempted patch from long ago that converts > ./autobuild.sh to use a VPATH build. My modified autobuild.sh ended up testing 'make install' from a VPATH build, and that failed miserably: for h in html/index.html html/libvirt-libvirt.html html/libvirt-virterror.html; do \ /usr/bin/install -c -m 0644 ../../docs/$h /home/remote/eblake/builder/share/doc/libvirt-0.8.7/html/html; done /usr/bin/install: cannot stat `../../docs/html/index.html': No such file or directory /usr/bin/install: cannot stat `../../docs/html/libvirt-libvirt.html': No such file or directory /usr/bin/install: cannot stat `../../docs/html/libvirt-virterror.html': No such file or directory At least the failure looks like it is contained within Makefile.am, so it shouldn't be too hard to fix as a followup patch (at least, I'm working on that effort now). -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list