On 02/16/2011 09:50 AM, Eric Blake wrote: > On 02/16/2011 09:41 AM, Eric Blake wrote: >> On 02/16/2011 09:01 AM, Jiri Denemark wrote: >>> Even VPATH make dist succeeds now > >> >> ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c >> code, and since it makes the tarball more useful. > > I still maintain the ACK, and would like to see this go in as-is. > However, this patch is incomplete... > >> >> And I'm going to dig up my attempted patch from long ago that converts >> ./autobuild.sh to use a VPATH build. > > My modified autobuild.sh ended up testing 'make install' from a VPATH > build, and that failed miserably: > > for h in html/index.html html/libvirt-libvirt.html > html/libvirt-virterror.html; do \ > /usr/bin/install -c -m 0644 ../../docs/$h > /home/remote/eblake/builder/share/doc/libvirt-0.8.7/html/html; done > /usr/bin/install: cannot stat `../../docs/html/index.html': No such file > or directory Huh. I think I may have found part of the problem, but I'm still not sure of the solution. When building from a tarball, docs/index.html exists alongside docs/index.html.in. But when running ./autobuild.sh from a fresh git clone, docs/index.html has not been generated yet. In that case, the file gets generated into builddir rather than srcdir, which breaks all sorts of other assumptions. Let's not push anything until after the 0.8.8 release, when we can get better resolution on what's (not) going on here. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list