On 02/16/2011 09:01 AM, Jiri Denemark wrote: > Even VPATH make dist succeeds now > --- > docs/Makefile.am | 8 ++++---- > docs/apibuild.py | 23 +++++++++++++---------- > 2 files changed, 17 insertions(+), 14 deletions(-) > > diff --git a/docs/Makefile.am b/docs/Makefile.am > index 473bbbf..8c96e79 100644 > --- a/docs/Makefile.am > +++ b/docs/Makefile.am > @@ -92,7 +92,7 @@ MAINTAINERCLEANFILES = $(dot_html) $(apihtml) $(devhelphtml) > > all: web > > -api: libvirt-api.xml libvirt-refs.xml > +api: $(srcdir)/libvirt-api.xml $(srcdir)/libvirt-refs.xml Makes sense that you generate the api .xml files in srcdir, since they are supposed to be part of the tarball, present even for people that lack the tools to rebuild them. > @@ -179,7 +179,7 @@ clean-local: > rm -f *~ *.bak *.hierarchy *.signals *-unused.txt *.html > > maintainer-clean-local: clean-local > - rm -rf libvirt-api.xml libvirt-refs.xml todo.html.in > + rm -rf $(srcdir)/libvirt-api.xml $(srcdir)/libvirt-refs.xml todo.html.in Good that they are only removed for the maintainer, and not for ordinary builds. I'm not that fluent in python, but your changes seemed reasonable from appearance, and more importantly, I tested this patch in my own VPATH setup with success. ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c code, and since it makes the tarball more useful. And I'm going to dig up my attempted patch from long ago that converts ./autobuild.sh to use a VPATH build. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list