2011/1/4 Eric Blake <eblake@xxxxxxxxxx>: > On 12/30/2010 10:14 AM, Matthias Bolte wrote: >> Update test suite accordingly. > >> + >> + Â ÂvirBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n", >> + Â Â Â Â Â Â Â Â Â Â Âdef->vram * 1024); /* Scale from kilobytes to bytes */ > > Should this be %lld, def->vram * 1024ll, to avoid overflow concerns? Sure, doesn't hurt to do so. > Otherwise, it looks okay to me. ÂConditional ACK based on the answer to > that question. Thanks, I folded in the LL suggestion and pushed the result. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list