Re: [PATCH] vbox: Use correct VRAM size unit

[Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx>]

2011/1/4 Eric Blake <eblake@xxxxxxxxxx>:
> On 12/30/2010 07:27 AM, Matthias Bolte wrote:
>> VirtualBox uses megabyte, libvirt uses kilobyte.
>> ---
>> Âsrc/vbox/vbox_tmpl.c | Â Â6 +++---
>> Â1 files changed, 3 insertions(+), 3 deletions(-)
>
> Oops - this could have qualified for a bug fix, but I didn't review it
> pre-release, so it missed the window. ÂAt any rate,
>
>> @@ -2225,7 +2225,7 @@ static char *vboxDomainDumpXML(virDomainPtr dom, int flags) {
>> Â Â Â Â Â Â Â Â Âif (VIR_ALLOC_N(def->videos, def->nvideos) >= 0) {
>> Â Â Â Â Â Â Â Â Â Â Âif (VIR_ALLOC(def->videos[0]) >= 0) {
>> Â Â Â Â Â Â Â Â Â Â Â Â Â/* the default is: vram is 8MB, One monitor, 3dAccel Off */
>> -            ÂPRUint32 VRAMSize     Â= 8 * 1024;
>> +            ÂPRUint32 VRAMSize     Â= 8;
>>             ÂPRUint32 monitorCount   Â= 1;
>> Â Â Â Â Â Â Â Â Â Â Â Â ÂPRBool accelerate3DEnabled = PR_FALSE;
>> Â Â Â Â Â Â Â Â Â Â Â Â ÂPRBool accelerate2DEnabled = PR_FALSE;
>> @@ -2238,7 +2238,7 @@ static char *vboxDomainDumpXML(virDomainPtr dom, int flags) {
>> Â#endif /* VBOX_API_VERSION >= 3001 */
>>
>>             Âdef->videos[0]->type      Â= VIR_DOMAIN_VIDEO_TYPE_VBOX;
>> -            Âdef->videos[0]->vram      Â= VRAMSize;
>> +            Âdef->videos[0]->vram      Â= VRAMSize * 1024;
>>             Âdef->videos[0]->heads      = monitorCount;
>> Â Â Â Â Â Â Â Â Â Â Â Â Âif (VIR_ALLOC(def->videos[0]->accel) >= 0) {
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âdef->videos[0]->accel->support3d = accelerate3DEnabled;
>> @@ -4397,7 +4397,7 @@ vboxAttachVideo(virDomainDefPtr def, IMachine *machine)
>> Â{
>> Â Â Âif ((def->nvideos == 1) &&
>> Â Â Â Â Â(def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_VBOX)) {
>> - Â Â Â Âmachine->vtbl->SetVRAMSize(machine, def->videos[0]->vram);
>> + Â Â Â Âmachine->vtbl->SetVRAMSize(machine, def->videos[0]->vram / 1024);
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list