On 12/30/2010 10:14 AM, Matthias Bolte wrote: > Update test suite accordingly. > + > + virBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n", > + def->vram * 1024); /* Scale from kilobytes to bytes */ Should this be %lld, def->vram * 1024ll, to avoid overflow concerns? Otherwise, it looks okay to me. Conditional ACK based on the answer to that question. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list