On Wed, May 10, 2023 at 02:40:38PM +0200, Peter Krempa wrote: > On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote: > > Peter, is there a reason why we're still calling 'qemu-img create' > > for those specific images? Or could we replace those calls with > > preformatted images as well, and no longer use qemu-img from the test > > suite at all? > > The idea why I kept using freshly formatted images is to validate our > qcow2 header parser (we have our own, which is intentionally kept very > simple to only parse the format and backing image location) against the > current state of qemu, to catch potential regressions when qemu's format > would change. It's a form of integration testing albeit a bit weird in > how it's executed (notably it depeds on the system version of qemu-img > rather than doing anything specific to test against current upstream). Alright, so it makes sense to keep running qemu-img as part of the test suite and thus to have it as a build dependency. I'm just going to update the comment in the spec file and point out this usage explicitly, because it's clearly non-obvious right now. -- Andrea Bolognani / Red Hat / Virtualization
