On Wed, May 03, 2023 at 11:00:55AM +0200, Michal Privoznik wrote:
Neither of tests that use virfirewallmock.c (networkxml2firewalltest, nwfilterebiptablestest, nwfilterxml2firewalltest, virfirewalltest) really call virFindFileInPath(). But at least networkxml2firewalltest calls virFirewallDIsRegistered(), under the hood. Now, the actual implementation connects to dbus and something, which is
Is the "and something" a placeholder you forgot to replace? You can say "connects to dbus and lists the services" or even just "connects to dbus" is enough. The "something" seems weird there. With any of the versions applied Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
