On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote:
It's not used as part of the build process or even searched for at build time. The QEMU driver detects its path at runtime.
But we do run tests at build time and virstoragetest.c is looking for qemu-img and using it. Without it the tests would not fail, but would be skipped, which might be ever worse because we would not notice.
Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c542ec3b2b..69cafc8b91 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -310,8 +310,6 @@ BuildRequires: util-linux %if %{with_qemu} # For managing ACLs BuildRequires: libacl-devel -# From QEMU RPMs -BuildRequires: /usr/bin/qemu-img %endif # For LVM drivers BuildRequires: lvm2 -- 2.40.1
Attachment:
signature.asc
Description: PGP signature