On Wed, May 10, 2023 at 12:01:03PM +0200, Martin Kletzander wrote: > On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote: > > It's not used as part of the build process or even searched for > > at build time. The QEMU driver detects its path at runtime. > > But we do run tests at build time and virstoragetest.c is looking for > qemu-img and using it. Without it the tests would not fail, but would > be skipped, which might be ever worse because we would not notice. Good catch! You're right, we definitely don't want that. I see that we only have 3 calls to 'qemu-img create' in that test, with everything else being done via preformatted images that are stored in tests/virstoragetestdata/. Several more calls were present in the past, but the vast majority were dropped with [1]. Peter, is there a reason why we're still calling 'qemu-img create' for those specific images? Or could we replace those calls with preformatted images as well, and no longer use qemu-img from the test suite at all? [1] https://listman.redhat.com/archives/libvir-list/2021-September/222689.html -- Andrea Bolognani / Red Hat / Virtualization
