On Fri, Dec 23, 2022 at 04:30:32AM -0500, Andrea Bolognani wrote:
> On Thu, Dec 22, 2022 at 11:03:37AM -0700, Jim Fehlig wrote:
> > -Requires: polkit >= 0.112
> > %if %{with_dmidecode}
> > # For virConnectGetSysinfo
> > Requires: dmidecode
> > %endif
> > # For service management
> > Requires(post): /usr/bin/systemctl
> > -%if %{with_numad}
> > -Requires: numad
> > -%endif
> > -# libvirtd depends on 'messagebus' service
> > -Requires: dbus
> > -# For uid creation during pre
> > -Requires(pre): shadow-utils
> > +Requires: polkit >= 0.112
> > # Needed by /usr/libexec/libvirt-guests.sh script.
> > %if 0%{?fedora} >= 37
> > Requires: gettext-runtime
> > %else
> > Requires: gettext
> > %endif
> > +# libvirtd depends on 'messagebus' service
> > +Requires: dbus
> > +# For uid creation during pre
> > +Requires(pre): shadow-utils
>
> This looks like pure noise - AFAICT you could have left the requires
> for polkit, dbus and shadow-utils exactly where they already were. Is
> there a reason why you moved them?
One more thing. After your changes, libvirt-daemon still has
# netcat is needed on the server side so that clients that have
# libvirt < 6.9.0 can connect, but newer versions will prefer
# virt-ssh-helper. Making this a Recommends means that it gets
# installed by default, but can still be removed if compatibility
# with old clients is not required
Recommends: /usr/bin/nc
I think this should be moved to libvirt-daemon-common too, since
modular daemons were introduced before virt-ssh-helper and so it's
possible that old clients might try to connect to a modularized
deployment, which will fail if nc is not available.
--
Andrea Bolognani / Red Hat / Virtualization
