Re: [PATCH V4 08/11] spec: Add numad dependency to qemu and lxc drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 22, 2022 at 11:03:39AM -0700, Jim Fehlig wrote:
> Both drivers use numad via virNumaGetAutoPlacementAdvice.
>
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  libvirt.spec.in | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e69005bb42..c5adb1a2ba 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -763,6 +763,9 @@ Requires: lzop
>  Requires: xz
>  Requires: systemd-container
>  Requires: swtpm-tools
> +    %if %{with_numad}
> +Requires: numad
> +    %endif
>
>  %description daemon-driver-qemu
>  The qemu driver plugin for the libvirtd daemon, providing
> @@ -780,6 +783,9 @@ Requires: libvirt-daemon-driver-network = %{version}-%{release}
>  Requires: systemd-container
>  # for modprobe of nbd driver
>  Requires: module-init-tools
> +    %if %{with_numad}
> +Requires: numad
> +    %endif

Same comment as the previous patch: I think you should be able to
drop the dependency on numad from the libvirt-daemon package at this
point.

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux