On Thu, Dec 22, 2022 at 11:03:37AM -0700, Jim Fehlig wrote:
> +%package daemon-common
> +Summary: Files and utilities used by daemons
> +Requires: libvirt-libs = %{version}-%{release}
> +# The libvirt-guests.sh script requires virsh from libvirt-client subpackage,
> +# but not every deployment wants to use libvirt-guests service. Using
> +# Recommends here will install libvirt-client by default (if available), but
> +# RPM won't complain if the package is unavailable, masked, or removed later.
> +Recommends: libvirt-client = %{version}-%{release}
> # for /sbin/ip
> Requires: iproute
> # for /sbin/tc
> Requires: iproute-tc
> -Requires: polkit >= 0.112
> %if %{with_dmidecode}
> # For virConnectGetSysinfo
> Requires: dmidecode
> %endif
> # For service management
> Requires(post): /usr/bin/systemctl
> -%if %{with_numad}
> -Requires: numad
> -%endif
> -# libvirtd depends on 'messagebus' service
> -Requires: dbus
> -# For uid creation during pre
> -Requires(pre): shadow-utils
> +Requires: polkit >= 0.112
> # Needed by /usr/libexec/libvirt-guests.sh script.
> %if 0%{?fedora} >= 37
> Requires: gettext-runtime
> %else
> Requires: gettext
> %endif
> +# libvirtd depends on 'messagebus' service
> +Requires: dbus
> +# For uid creation during pre
> +Requires(pre): shadow-utils
This looks like pure noise - AFAICT you could have left the requires
for polkit, dbus and shadow-utils exactly where they already were. Is
there a reason why you moved them?
--
Andrea Bolognani / Red Hat / Virtualization
