Re: [PATCH 2/2] virt-driver-qemu.m4: Require YAJL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 13, 2019 at 04:50:38PM +0100, Michal Privoznik wrote:
There is not way that qemu driver can work without being able to

s/not/no/

format/parse JSON.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
m4/virt-driver-qemu.m4 | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
index 80e1d3ad46..af8edaae0d 100644
--- a/m4/virt-driver-qemu.m4
+++ b/m4/virt-driver-qemu.m4
@@ -26,6 +26,15 @@ AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
])

AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [
+  dnl There is no way qemu driver will work without JSON support
+  AC_REQUIRE([LIBVIRT_CHECK_YAJL])
+  if test "$with_qemu:$with_yajl" = "yes:no"; then
+    AC_MSG_ERROR([YAJL or YAJL2 is required to build QEMU driver])
+  fi
+  if test "$with_qemu" = "check"; then
+    with_qemu=$with_yajl
+  fi
+

Note that the default for with_qemu is still 'yes', so developers would
have to opt-in by passing --with-qemu=check

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux