On Thu, Mar 14, 2019 at 11:41:31AM +0100, Ján Tomko wrote: > On Wed, Mar 13, 2019 at 04:50:38PM +0100, Michal Privoznik wrote: > > There is not way that qemu driver can work without being able to > > s/not/no/ > > > format/parse JSON. > > > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > --- > > m4/virt-driver-qemu.m4 | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 > > index 80e1d3ad46..af8edaae0d 100644 > > --- a/m4/virt-driver-qemu.m4 > > +++ b/m4/virt-driver-qemu.m4 > > @@ -26,6 +26,15 @@ AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [ > > ]) > > > > AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [ > > + dnl There is no way qemu driver will work without JSON support > > + AC_REQUIRE([LIBVIRT_CHECK_YAJL]) > > + if test "$with_qemu:$with_yajl" = "yes:no"; then > > + AC_MSG_ERROR([YAJL or YAJL2 is required to build QEMU driver]) > > + fi > > + if test "$with_qemu" = "check"; then > > + with_qemu=$with_yajl > > + fi > > + > > Note that the default for with_qemu is still 'yes', so developers would > have to opt-in by passing --with-qemu=check IMHO we must fix that before we push this. We aim to have our default configure setup automatically probe things - raising a hard error by default when yajl is missing is not desirable unless the user has explicitly given --with-qemu=yes. > > Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list