On Wed, Mar 13, 2019 at 04:50:37PM +0100, Michal Privoznik wrote:
Firstly, this code is lacking AC_REQUIRE() therefore it may happen that this code is executed before LIBVIRT_DRIVER_CHECK_QEMU is evaluated.
Irrelevant. LIBVIRT_DRIVER_CHECK_QEMU does not actually change the with_qemu variable. It only depends on LIBVIRT_DRIVER_ARG_QEMU to set the default 'yes' or get the value from the command line.
Secondly, the code tries to detect installed version of qemu to learn if it uses HMP or QMP and enable YAJL based on that. Well, we support only QMP and also minimal required version of qemu is 1.5.0 so the check would have enabled yajl anyway.
IOW after this patch, not having YAJL is no longer fatal with the default ./configure command line on systems with a QEMU binary.
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- m4/virt-yajl.m4 | 20 -------------------- 1 file changed, 20 deletions(-)
With the irrelevant part of the commit message dropped: Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
