On Wed, 2018-06-06 at 12:04 +0200, Peter Krempa wrote: > On Wed, Jun 06, 2018 at 12:02:12 +0200, Andrea Bolognani wrote: > > On Wed, 2018-06-06 at 11:14 +1000, David Gibson wrote: > > > TBH, if the user is already thinking about page sizes at this low > > > level, I don't think doing it by shift is much of a stretch. > > > > I disagree that it's such a low level setting that only people who > > can do bitwise shifts off the top of their heads will want to > > tweak: if it were, then libvirt will probably not need to expose > > it in the first place :) > > Well, it will most probably be configured by some policy code from a > upper layer mgmt tool, so I don't think users will actually ever touch > it. Probably. Still not a good reason not to ensure it's human-friendly at every layer of the stack IMHO. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list