On 09/24/2016 12:04 AM, Joao Martins wrote:
> On September 23, 2016 11:05:57 PM GMT+01:00, Jim Fehlig <jfehlig@xxxxxxxx> wrote:
>> On 09/22/2016 01:53 PM, Joao Martins wrote:
>>> So far only guestfwd and virtio were supported. Add an additional
>>> for Xen as libxl channels create Xen console visible to the guest.
>>>
>>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
>>> ---
>>> docs/schemas/domaincommon.rng | 11 +++++++++++
>>> src/conf/domain_conf.c | 18 ++++++++++++++----
>>> src/conf/domain_conf.h | 1 +
>>> src/qemu/qemu_command.c | 1 +
>>> 4 files changed, 27 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/docs/schemas/domaincommon.rng
>> b/docs/schemas/domaincommon.rng
>>> index 95c7882..6eeb4e9 100644
>>> --- a/docs/schemas/domaincommon.rng
>>> +++ b/docs/schemas/domaincommon.rng
>>> @@ -3690,6 +3690,16 @@
>>> </optional>
>>> </element>
>>> </define>
>>> + <define name="xenTarget">
>>> + <element name="target">
>>> + <attribute name="type">
>>> + <value>xen</value>
>>> + </attribute>
>>> + <optional>
>>> + <attribute name="name"/>
>>> + </optional>
>>> + </element>
>>> + </define>
>>> <define name="channel">
>>> <element name="channel">
>>> <ref name="qemucdevSrcType"/>
>>> @@ -3698,6 +3708,7 @@
>>> <choice>
>>> <ref name="guestfwdTarget"/>
>>> <ref name="virtioTarget"/>
>>> + <ref name="xenTarget"/>
>>> </choice>
>>> <optional>
>>> <ref name="alias"/>
>>
>> Sorry for not mentioning this while reviewing V1, but changes to the
>> domain
>> schema typically need a corresponding change to docs/formatdomain.html.
>> I think
>> it behooves us to mention the Xen support in the 'channels' section of
>> that page.
>
> Ah good point, let me add it to v3. I will
> send it before the freeze.
I'll adding this to the docs:
<dt><code>xen</code></dt>
<dd> Paravirtualized xen channel. Channel is exposed in the guest as a
xen console but identified with a name. The setup of the channel
depends to guest own rules and can live in a arbitrary path (for more
info, please see <a
href="http://xenbits.xen.org/docs/unstable/misc/channel.txt";>http://xenbits.xen.org/docs/unstable/misc/channel.txt</a>).
Channel source path semantics are the same as the virtio target type.
Although <code>state</code> attribute is not provided as xen channels
lack the necessary probing mechanism.
<span class="since">Since 2.3.0</span>
</dd>
Joao
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list