Re: [PATCH v2 1/4] conf: add xen type for channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On September 23, 2016 11:05:57 PM GMT+01:00, Jim Fehlig <jfehlig@xxxxxxxx> wrote:
>On 09/22/2016 01:53 PM, Joao Martins wrote:
>> So far only guestfwd and virtio were supported. Add an additional
>> for Xen as libxl channels create Xen console visible to the guest.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
>> ---
>>  docs/schemas/domaincommon.rng | 11 +++++++++++
>>  src/conf/domain_conf.c        | 18 ++++++++++++++----
>>  src/conf/domain_conf.h        |  1 +
>>  src/qemu/qemu_command.c       |  1 +
>>  4 files changed, 27 insertions(+), 4 deletions(-)
>>
>> diff --git a/docs/schemas/domaincommon.rng
>b/docs/schemas/domaincommon.rng
>> index 95c7882..6eeb4e9 100644
>> --- a/docs/schemas/domaincommon.rng
>> +++ b/docs/schemas/domaincommon.rng
>> @@ -3690,6 +3690,16 @@
>>        </optional>
>>      </element>
>>    </define>
>> +  <define name="xenTarget">
>> +    <element name="target">
>> +      <attribute name="type">
>> +        <value>xen</value>
>> +      </attribute>
>> +      <optional>
>> +        <attribute name="name"/>
>> +      </optional>
>> +    </element>
>> +  </define>
>>    <define name="channel">
>>      <element name="channel">
>>        <ref name="qemucdevSrcType"/>
>> @@ -3698,6 +3708,7 @@
>>          <choice>
>>            <ref name="guestfwdTarget"/>
>>            <ref name="virtioTarget"/>
>> +          <ref name="xenTarget"/>
>>          </choice>
>>          <optional>
>>            <ref name="alias"/>
>
>Sorry for not mentioning this while reviewing V1, but changes to the
>domain
>schema typically need a corresponding change to docs/formatdomain.html.
>I think
>it behooves us to mention the Xen support in the 'channels' section of
>that page.

Ah good point, let me add it to v3. I will
 send it before the freeze.

Joao


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]