Re: [PATCH 01/13] qemu: refactor qemuBuildControllerDevStr to eliminate future duplicate code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 22, 2015 at 02:44:06PM -0400, Laine Stump wrote:
> The PCI case of the switch statement in this function contains another
> switch statement with a case for each model. Currently every model
> except pci-root and pcie-root have a check for index > 0 (since only

every model has

> those two can have index==0), and the function should never be called
> for those two anyway. If we move the check for !pci[e]-root to the top
> of the pci case, then we can move the check for index > 0 out of the
> individual model cases. This will save repeating that check for the
> three new controller models about to be added.
> ---
>  src/qemu/qemu_command.c | 27 ++++++++++++---------------
>  1 file changed, 12 insertions(+), 15 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]