On Mon, Jun 22, 2015 at 02:44:07PM -0400, Laine Stump wrote: > When support for the pcie-root and dmi-to-pci-bridge buses on a Q35 > machinetype was added, I was concerned that even though qemu at the > time allowed plugging a PCI device into a PCIe port, that it might not > be supported in the future. To prevent painful backtracking in the > possible future where this happened, I disallowed such connections > except in a few specific cases requested by qemu developers (indicated > in the code with the flag VIR_PCI_CONNEcT_TYPE_EITHER_IF_CONFIG). s/CONNEcT/CONNECT/g > > Now that a couple years have passed, there is a clear message from > qemu that there is no danger in allowing PCI devices to be plugged > into PCIe ports. This patch eliminates > VIR_PCI_CONNECT_TYPE_EITHER_IF_CONFIG and changes the code to always > allow PCI->PCIe or PCIe->PCI connection *when the PCI address is > specified in the config. (For newly added devices that haven't yet > been given a PCI address, the auto-placement still prefers using the > correct type of bus). > --- > docs/formatdomain.html.in | 18 +++++++++++------- > src/conf/domain_addr.c | 18 +++++++++++------- > src/conf/domain_addr.h | 16 ++++++++++------ > src/qemu/qemu_command.c | 6 ++---- > 4 files changed, 34 insertions(+), 24 deletions(-) > ACK Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list