Am 13.03.2015 um 20:45 schrieb Eduardo Habkost: > On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas Färber wrote: >> Only thing that comes to mind is whether it might make sense to >> hierarchically make Broadwell the parent type of Broadwell-noTSX, to >> avoid duplication. But then again we already have a lot of it. ;) > > The builtin_x86_defs[] table has no way to represent inheritance, > currently. Maybe one day when we move everything inside class_init > functions. :) If x86_cpu_compat_set_features(), x86_cpu_list() and arch_query_cpu_definitions() get fixed to no longer operate on the old builtin_x86_defs[] but on object_class_foreach() or similar functions, then you can register special CPU types in x86_cpu_register_types(), like we do for the KVM host type already. In this case I imagined a custom class_init with an &= ~... operation. But I wasn't aware we're still using the array in so many places! :/ Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list