On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas Färber wrote: > Am 13.03.2015 um 20:09 schrieb Eduardo Habkost: > > With the Intel microcode update that removed HLE and RTM, there will be > > different kinds of Haswell and Broadwell CPUs out there: some that still > > have the HLE and RTM features, and some that don't have the HLE and RTM > > features. On both cases people may be willing to use the pc-*-2.3 > > machine-types. > > > > So instead of making the CPU model results confusing by making it depend on the > > machine-type, keep HLE and RTM on the existing Haswell and Broadwell CPU > > models, and introduce "Haswell-noTSX" and "Broadwell-noTSX" CPU models later, > > for people who have CPUs that don't have TSX feature available. > > > > Eduardo Habkost (2): > > Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell" > > target-i386: Haswell-noTSX and Broadwell-noTSX > > No objections from a generic CPU point of view. > > Only thing that comes to mind is whether it might make sense to > hierarchically make Broadwell the parent type of Broadwell-noTSX, to > avoid duplication. But then again we already have a lot of it. ;) The builtin_x86_defs[] table has no way to represent inheritance, currently. Maybe one day when we move everything inside class_init functions. :) -- Eduardo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list