Re: [PATCH] virsh: fix report of non-active commit completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/13/2015 07:47 PM, John Ferlan wrote:
> 
> 
> On 03/13/2015 12:04 PM, Eric Blake wrote:
>> Commit f182da20 (v1.2.6) caused a slight regression in virsh
>> reporting of a non-active block job; where it used to state
>> "Commit complete", it now states "Now in synchronized phase".
>> But the synchronized phase is only possible for an active commit.
>>
>> For a reproducer, I created a chain 'a <- b <- c <- d <- e' and
>> ran virsh blockcommit $dom vda --top c --base a --verbose --wait
>>
>> * tools/virsh-domain.c (cmdBlockCommit): Synchronized phase is
>> only possible on active commits.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>  tools/virsh-domain.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK

I've pushed this and the other two you reviewed today. Thanks for the
review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]