On Thu, Jun 20, 2019 at 07:03:44PM +0200, Fabiano Fidêncio wrote: > On Thu, Jun 20, 2019 at 6:51 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > > > On Thu, Jun 20, 2019 at 05:21:20PM +0200, Fabiano Fidêncio wrote: > > > As config.h is not used, at all, in osinfo-db-tools, let's just stop > > > generating and including the file. > > > > Not entirely true. It is used for the GETTEXT_PACKAGE macro. Fortunately > > it seems that when you kill the AC_CONFIG_HEADER macro from configure, > > it automatically switches to pass -DGETTEXT_PACKAGE=... as a compiler > > arg instead so things still work > > I thought the GETTEXT_PACKAGE macro was defined here > https://gitlab.com/libosinfo/osinfo-db-tools/blob/master/configure.ac#L46 > and the info in config.h was just redundant. That's what gets substituted into config.h and/or CFLAGS Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
