On Thu, Jun 20, 2019 at 7:18 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Thu, Jun 20, 2019 at 05:21:26PM +0200, Fabiano Fidêncio wrote: > > Let's take advantage of that we can run `make syntax-check` without the > > need of having a Makefile around and add a `ninja syntax-check` target > > that ends up calling `make syntax-check`. > > It feels a little odd to be doing this while still having a GNUmakefile > in the top level source dir. It does make sense from the POV of having > a consistent story wrt use of ninja though. > > Perhaps we should hide the cfg.mk / GNUmakefile in build-aux dir too ? > > In fact I wonder if we can just cull GNUmakefile too putting any extra > bits into maint.mk instead. That way a plain "make" won't do anything. I tried to simplify it a bit and gave up in the middle of the process as I'd like to have this series out before going to PTO. I'll get back to this approach and submit a v2 next week. > > > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> > > --- > > build-aux/syntax-check.sh | 5 +++++ > > meson.build | 3 +++ > > 2 files changed, 8 insertions(+) > > create mode 100755 build-aux/syntax-check.sh > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
